Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip #2256

Open
wants to merge 4 commits into
base: spr/main/96859c27
Choose a base branch
from
Open

wip #2256

wants to merge 4 commits into from

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Nov 24, 2024 •
edited
Loading

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This was referenced Nov 24, 2024
Closed
Closed
@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 24, 2024 •
edited
Loading

Artifacts upload workflows:

@codecov Codecov
Copy link

codecov bot commented Nov 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.08%. Comparing base (798be68) to head (6f4715f).

Files with missing lines Patch % Lines
...rknet_sequencer_node/src/test_utils/compilation.rs 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@                  Coverage Diff                   @@
##           spr/main/96859c27    #2256       +/-   ##
======================================================
- Coverage             100.00%   77.08%   -22.92%     
======================================================
  Files                      2      386      +384     
  Lines                     31    40371    +40340     
  Branches                  31    40371    +40340     
======================================================
+ Hits                      31    31122    +31091     
- Misses                     0     6955     +6955     
- Partials                   0     2294     +2294

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from spr/main/6207c777 to main November 25, 2024 09:40
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware mentioned this pull request Nov 25, 2024
Merged
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from main to spr/main/96859c27 November 25, 2024 09:40
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the spr/main/96859c27 branch 6 times, most recently from f92053a to ae3a0f8 Compare November 25, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Itay-Tsabary-Starkware @reviewable-StarkWare